Akanksha-kedia commented on PR #17189: URL: https://github.com/apache/pinot/pull/17189#issuecomment-3544663485
Thanks for the review , lets go with standard On Tue, 18 Nov 2025 at 6:56 AM, Xiaotian (Jackie) Jiang < ***@***.***> wrote: > ***@***.**** commented on this pull request. > > Thanks for the contribution! This fills a big gap > ------------------------------ > > In > pinot-common/src/main/java/org/apache/pinot/common/function/scalar/LogicalFunctions.java > <https://github.com/apache/pinot/pull/17189#discussion_r2535998210>: > > > + * TRUE | FALSE | FALSE > + * TRUE | NULL | NULL > + * FALSE | TRUE | FALSE > + * FALSE | FALSE | FALSE > + * FALSE | NULL | FALSE > + * NULL | TRUE | NULL > + * NULL | FALSE | FALSE > + * NULL | NULL | NULL > + * </pre> > + * > + * @param a First boolean value (nullable) > + * @param b Second boolean value (nullable) > + * @return The logical AND result, or NULL if result cannot be determined > + */ > + @Nullable > + @ScalarFunction(names = {"logicalAnd", "logical_and", "and"}, nullableParameters = true) > > Do we want to call it logicalAnd or simply and? Is logicalAnd a standard > SQL function? > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/pinot/pull/17189#pullrequestreview-3475125185>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AVL2AZVHVNED4A2SLGOTHWL35JYTTAVCNFSM6AAAAACLYKVTRSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTINZVGEZDKMJYGU> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
