Jackie-Jiang commented on code in PR #17088:
URL: https://github.com/apache/pinot/pull/17088#discussion_r2535751654
##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/StreamMetadataProvider.java:
##########
@@ -86,7 +87,26 @@ StreamPartitionMsgOffset
fetchStreamPartitionOffset(OffsetCriteria offsetCriteri
default List<PartitionGroupMetadata> computePartitionGroupMetadata(String
clientId, StreamConfig streamConfig,
List<PartitionGroupConsumptionStatus> partitionGroupConsumptionStatuses,
int timeoutMillis)
throws IOException, TimeoutException {
- int partitionCount = fetchPartitionCount(timeoutMillis);
+
+ int partitionCount;
+ try {
+ partitionCount = fetchPartitionCount(timeoutMillis);
Review Comment:
IIUC, this part is processing a single stream. If we want to handle the case
of multiple topics with one topic deleted, we should handle it on the caller
side instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
