krishan1390 commented on code in PR #17183:
URL: https://github.com/apache/pinot/pull/17183#discussion_r2532702831
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/readers/PinotSegmentColumnReaderImpl.java:
##########
@@ -98,6 +214,94 @@ public String getColumnName() {
return _columnName;
}
+ @Override
+ public int getTotalDocs() {
+ return _numDocs;
+ }
+
+ @Override
+ public boolean isNull(int docId) {
+ validateDocId(docId);
+ return _segmentColumnReader.isNull(docId);
+ }
+
+ // Single-value accessors
+
+ @Override
+ public int getInt(int docId) {
+ return _segmentColumnReader.getInt(docId);
Review Comment:
Not required because _segmentColumnReader.getInt() has the required
validations and fails with IndexOutOfBoundsException. This is validated in
PinotSegmentColumnReaderImplTest.testBoundaryConditions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
