krishan1390 commented on code in PR #17190:
URL: https://github.com/apache/pinot/pull/17190#discussion_r2527384131
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ControllerTimer.java:
##########
@@ -38,7 +38,10 @@ public enum ControllerTimer implements AbstractMetrics.Timer
{
DEEP_STORE_SEGMENT_WRITE_TIME_MS("deepStoreSegmentWriteTimeMs", true),
// Audit logging timers
AUDIT_REQUEST_PROCESSING_TIME("auditRequestProcessingTime", true),
- AUDIT_RESPONSE_PROCESSING_TIME("auditResponseProcessingTime", true);
+ AUDIT_RESPONSE_PROCESSING_TIME("auditResponseProcessingTime", true),
+ // Log subtask waiting (until not started) and running (until not completed)
time
+ SUBTASK_WAITING_TIME("subtaskWaitingTime", false),
Review Comment:
I think waiting time should be global.
Running time is fine to be table level because its directly impacted by
tables.
But waiting time depends on other running tasks and there is no relation to
which table's task is running or waiting. So having a global metric will be
useful
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
