Copilot commented on code in PR #17207:
URL: https://github.com/apache/pinot/pull/17207#discussion_r2525388881
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/LeafOperator.java:
##########
@@ -460,6 +461,9 @@ void execute() {
try {
// Drain the latch when receiving exception block and not wait for
the other thread to finish
executeOneRequest(request, latch::countDown);
+ } catch (Throwable t) {
+ // TODO: We need to propagate this error back
+ LOGGER.error("Caught exception while executing leaf stage on
hybrid table", t);
Review Comment:
The TODO comment indicates incomplete error handling. Currently, exceptions
caught here are only logged but not propagated, which could hide failures in
hybrid table queries. Consider implementing proper error propagation (e.g.,
calling `setErrorBlock` similar to line 430-431) or creating a tracking issue
to address this.
```suggestion
LOGGER.error("Caught exception while executing leaf stage on
hybrid table", t);
setErrorBlock(new ErrorMseBlock(QueryErrorCode.SERVER_ERROR,
"Exception in hybrid table leaf stage: " + t.getMessage(), t));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
