Jackie-Jiang commented on code in PR #17039:
URL: https://github.com/apache/pinot/pull/17039#discussion_r2524849682
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/TransformFunction.java:
##########
@@ -171,4 +172,55 @@ default void init(List<TransformFunction> arguments,
Map<String, ColumnContext>
*/
@Nullable
RoaringBitmap getNullBitmap(ValueBlock block);
+
+ /**
+ * Validates transform function configuration during table creation.
+ */
+ default void validateIngestionConfig(String transformFunctionExpression,
org.apache.pinot.spi.data.Schema schema) {
+ // Default: no validation
+ }
+
+ /**
+ * Returns whether this function supports ingestion-time transformation.
+ */
+ default boolean supportsIngestionTransform() {
Review Comment:
Ingestion transform is not using `TransformFunction`, but scalar function. I
feel the framework should be built on scalar function, or `FunctionRegistry`
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/TransformFunction.java:
##########
@@ -171,4 +172,55 @@ default void init(List<TransformFunction> arguments,
Map<String, ColumnContext>
*/
@Nullable
RoaringBitmap getNullBitmap(ValueBlock block);
+
+ /**
+ * Validates transform function configuration during table creation.
+ */
+ default void validateIngestionConfig(String transformFunctionExpression,
org.apache.pinot.spi.data.Schema schema) {
Review Comment:
Replace with proper import, same for other places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
