krishan1390 commented on PR #17186: URL: https://github.com/apache/pinot/pull/17186#issuecomment-3516927047
@xiangfu0 We added 10% overestimation to prevent unknown issues if approx cardinality < actual cardinality. HLL has an upper bound of error so adding 10% buffer guarantees that approx cardinality > actual cardinality when unique elements > threshold. For flakiness in tests when unique elements < threshold, I plan to store unique values upto a threshold so that we get actual cardinality in such cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
