tibrewalpratik17 commented on code in PR #17104:
URL: https://github.com/apache/pinot/pull/17104#discussion_r2487142553
##########
pinot-core/src/main/java/org/apache/pinot/core/common/MinionConstants.java:
##########
@@ -316,6 +316,18 @@ public static class UpsertCompactMergeTask {
*/
public static final long DEFAULT_MAX_NUM_SEGMENTS_PER_TASK = 10;
+ /**
+ * minimum number of segments to process in a single task
+ */
+ public static final String MIN_NUM_SEGMENTS_PER_TASK_KEY =
"minNumSegmentsPerTask";
+
+ /**
+ * default minimum number of segments to process in a single task.
+ * Keeping this default to 2 means that we won't run this task if there is
only one segment which can be merged.
+ * If this is set to 1, this task can act as UpsertCompact task as well.
Review Comment:
Can we add a check in config-validator that if this is set to 1,
UpsertCompactionTask config should not be present to avoid in-deterministic
behaviour of newly created compacted segments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
