Copilot commented on code in PR #17108:
URL: https://github.com/apache/pinot/pull/17108#discussion_r2476046362
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -1106,7 +1106,7 @@ public Map<String, PartitionLagState>
getPartitionToLagState(
*/
private void reportDataLoss(MessageBatch messageBatch) {
if (messageBatch.hasDataLoss()) {
- _serverMetrics.setValueOfTableGauge(_tableStreamName,
ServerGauge.STREAM_DATA_LOSS, 1L);
+ _serverMetrics.setValueOfTableGauge(_clientId,
ServerGauge.STREAM_DATA_LOSS, 1L);
Review Comment:
The fix assumes `_clientId` is the correct variable to use, but without
seeing the full context of how metrics are cleaned up or the initialization of
both `_tableStreamName` and `_clientId`, this change could introduce
inconsistency. Verify that all other STREAM_DATA_LOSS metric operations
(including cleanup) use `_clientId` as the key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
