somandal commented on code in PR #17028:
URL: https://github.com/apache/pinot/pull/17028#discussion_r2467344276
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentIndexCreationDriverImpl.java:
##########
@@ -578,10 +578,26 @@ private void buildStarTreeV2IfNecessary(File indexDir)
if (CollectionUtils.isNotEmpty(starTreeIndexConfigs) ||
enableDefaultStarTree) {
MultipleTreesBuilder.BuildMode buildMode =
_config.isOnHeap() ? MultipleTreesBuilder.BuildMode.ON_HEAP :
MultipleTreesBuilder.BuildMode.OFF_HEAP;
- try (
- MultipleTreesBuilder builder = new
MultipleTreesBuilder(starTreeIndexConfigs, enableDefaultStarTree, indexDir,
- buildMode)) {
+ MultipleTreesBuilder builder = new
MultipleTreesBuilder(starTreeIndexConfigs, enableDefaultStarTree, indexDir,
+ buildMode);
+ try {
builder.build();
+ } catch (Exception e) {
+ String tableNameWithType = _config.getTableConfig().getTableName();
+ LOGGER.error("Failed to build star-tree index for table: {},
skipping", tableNameWithType, e);
+ if (_instanceType == InstanceType.MINION) {
+ MinionMetrics.get().addMeteredTableValue(tableNameWithType,
MinionMeter.STAR_TREE_INDEX_BUILD_FAILURES, 1);
+ } else {
+ ServerMetrics.get().addMeteredTableValue(tableNameWithType,
ServerMeter.STAR_TREE_INDEX_BUILD_FAILURES, 1);
+ }
+ } finally {
+ try {
+ builder.close();
+ } catch (Exception e) {
+ LOGGER.error("Closing builder threw an exception, potentially
leaving the star-tree index in an "
+ + "inconsistent state, throwing exception", e);
+ throw e;
Review Comment:
good point, done
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentIndexCreationDriverImpl.java:
##########
@@ -578,10 +578,26 @@ private void buildStarTreeV2IfNecessary(File indexDir)
if (CollectionUtils.isNotEmpty(starTreeIndexConfigs) ||
enableDefaultStarTree) {
MultipleTreesBuilder.BuildMode buildMode =
_config.isOnHeap() ? MultipleTreesBuilder.BuildMode.ON_HEAP :
MultipleTreesBuilder.BuildMode.OFF_HEAP;
- try (
- MultipleTreesBuilder builder = new
MultipleTreesBuilder(starTreeIndexConfigs, enableDefaultStarTree, indexDir,
- buildMode)) {
+ MultipleTreesBuilder builder = new
MultipleTreesBuilder(starTreeIndexConfigs, enableDefaultStarTree, indexDir,
+ buildMode);
+ try {
builder.build();
+ } catch (Exception e) {
+ String tableNameWithType = _config.getTableConfig().getTableName();
+ LOGGER.error("Failed to build star-tree index for table: {},
skipping", tableNameWithType, e);
+ if (_instanceType == InstanceType.MINION) {
+ MinionMetrics.get().addMeteredTableValue(tableNameWithType,
MinionMeter.STAR_TREE_INDEX_BUILD_FAILURES, 1);
+ } else {
+ ServerMetrics.get().addMeteredTableValue(tableNameWithType,
ServerMeter.STAR_TREE_INDEX_BUILD_FAILURES, 1);
+ }
+ } finally {
+ try {
+ builder.close();
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
