hongkunxu commented on code in PR #16890:
URL: https://github.com/apache/pinot/pull/16890#discussion_r2464473168
##########
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/LaunchDataIngestionJobCommand.java:
##########
@@ -44,13 +44,13 @@ public class LaunchDataIngestionJobCommand extends
AbstractBaseAdminCommand impl
private static final Logger LOGGER =
LoggerFactory.getLogger(LaunchDataIngestionJobCommand.class);
@CommandLine.Option(names = {"-jobSpecFile", "-jobSpec"}, required = true,
description = "Ingestion job spec file")
- private String _jobSpecFile;
+ protected String _jobSpecFile;
@CommandLine.Option(names = {"-values"}, required = false, arity = "1..*",
description = "Context values set to the job spec template")
- private List<String> _values;
+ protected List<String> _values;
@CommandLine.Option(names = {"-propertyFile"}, required = false,
description = "A property file contains context values to set the job
spec template")
- private String _propertyFile;
+ protected String _propertyFile;
@CommandLine.Option(names = {"-user"}, required = false, description =
"Username for basic auth.")
private String _user;
Review Comment:
Sure. I will make related auth options as protected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
