Copilot commented on code in PR #17076:
URL: https://github.com/apache/pinot/pull/17076#discussion_r2462171693
##########
.github/workflows/pinot_tests.yml:
##########
@@ -352,6 +364,18 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
fail_ci_if_error: false
verbose: true
+ - name: Generate Surefire Report
+ if: ${{ !cancelled() && github.ref == 'refs/heads/master' }}
+ run: mvn surefire-report:report-only -P github-actions,codecoverage ||
echo "Surefire report generation failed, but continuing..."
+ - name: Upload Surefire Reports
+ if: ${{ !cancelled() && github.ref == 'refs/heads/master' }}
+ uses: actions/upload-artifact@v4
+ with:
+ name: surefire-reports-integration-test-${{ matrix.testset
}}-${{matrix.distribution}}-${{matrix.java}}
Review Comment:
Inconsistent spacing in variable interpolation. The `matrix.testset` uses
spaces around the variable (`${{ matrix.testset }}`), while
`matrix.distribution` and `matrix.java` don't (`${{matrix.distribution}}`,
`${{matrix.java}}`). Use consistent spacing: either `${{ matrix.variable }}` or
`${{matrix.variable}}` throughout.
##########
.github/workflows/pinot_tests.yml:
##########
@@ -233,6 +233,18 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
fail_ci_if_error: false
verbose: true
+ - name: Generate Surefire Report
+ if: ${{ !cancelled() && github.ref == 'refs/heads/master' }}
+ run: mvn surefire-report:report-only -P
github-actions,codecoverage,no-integration-tests || echo "Surefire report
generation failed, but continuing..."
+ - name: Upload Surefire Reports
+ if: ${{ !cancelled() && github.ref == 'refs/heads/master' }}
+ uses: actions/upload-artifact@v4
+ with:
+ name: surefire-reports-unit-test-${{ matrix.testset
}}-${{matrix.distribution}}-${{matrix.java}}
Review Comment:
Inconsistent spacing in variable interpolation. The `matrix.testset` uses
spaces around the variable (`${{ matrix.testset }}`), while
`matrix.distribution` and `matrix.java` don't (`${{matrix.distribution}}`,
`${{matrix.java}}`). Use consistent spacing: either `${{ matrix.variable }}` or
`${{matrix.variable}}` throughout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
