somandal commented on code in PR #17057:
URL: https://github.com/apache/pinot/pull/17057#discussion_r2456811089
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentIndexCreationDriverImpl.java:
##########
@@ -120,11 +123,18 @@ public class SegmentIndexCreationDriverImpl implements
SegmentIndexCreationDrive
private int _incompleteRowsFound = 0;
private int _skippedRowsFound = 0;
private int _sanitizedRowsFound = 0;
+ private @Nullable InstanceType _instanceType;
@Override
public void init(SegmentGeneratorConfig config)
throws Exception {
- init(config, getRecordReader(config));
+ init(config, getRecordReader(config), null);
Review Comment:
actually it's not only used in tests. seems that some commands and ops
outside of the basic minion / server ones call this too
e.g.
`SegmentOps`
`MemoryEstimator`
`IngestionUtils`
`BenchmarkOfflineIndexReader` (and the other init() which doesn't take
InstanceType is also called from a bunch of these benchmark classes)
`CreateSegmentCommand`
Apologies, should've mentioned it, but the init() functions are called from
a wide variety of classes. I've only tried to cover the MINION and SERVER
related ones and allowed passing null from others as I didn't think having a
metric for those was really that relevant. let me know if you think otherwise
though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
