yashmayya commented on code in PR #17042:
URL: https://github.com/apache/pinot/pull/17042#discussion_r2446252409
##########
pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/util/SegmentDeletionManagerTest.java:
##########
@@ -629,26 +629,34 @@ public boolean mkdir(URI uri)
throws IOException {
// create a new table Dir if the path ends with /
if (uri.getPath().endsWith("/")) {
- _tableDirs.put(uri.getPath(), new HashSet<>());
+ synchronized (_tableDirs) {
Review Comment:
What's the threading model here? Can you add a comment on why this
synchronized block is needed? And it's needed even though this `FakePinotFs` is
only being used for `testRemoveDeletedSegmentsForGcsPinotFS` which is a single
threaded test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
