Jackie-Jiang commented on code in PR #16728:
URL: https://github.com/apache/pinot/pull/16728#discussion_r2373767389
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/BaseCombineOperator.java:
##########
@@ -92,26 +96,122 @@ protected BaseCombineOperator(ResultsBlockMerger<T>
resultsBlockMerger, List<Ope
_futures = new Future[_numTasks];
}
+ @Override
+ public List<Operator> getChildOperators() {
+ return _operators;
+ }
+
+ /// Do not check termination in combine operator to ensure [#nextBlock()]
returns a results block instead of
+ /// throwing exception.
Review Comment:
Added more comments to the `BaseCombineOperator` javadoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
