noob-se7en commented on code in PR #16904:
URL: https://github.com/apache/pinot/pull/16904#discussion_r2387293403
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -2654,18 +2654,6 @@ public void
repairSegmentsInErrorStateForPauselessConsumption(TableConfig tableC
continue;
}
- // Skip segments that are not ONLINE in ideal state
- boolean hasOnlineInstance = false;
- for (String state : idealStateMap.values()) {
- if (SegmentStateModel.ONLINE.equals(state)) {
- hasOnlineInstance = true;
- break;
- }
- }
- if (!hasOnlineInstance) {
- continue;
- }
-
Review Comment:
COMMITTING segments must always be online. Rest all error segments not
having committing zk status must be reset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
