yashmayya commented on code in PR #16992:
URL: https://github.com/apache/pinot/pull/16992#discussion_r2418201897
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/TransformFunctionFactory.java:
##########
@@ -324,6 +323,15 @@ public static TransformFunction get(ExpressionContext
expression, Map<String, Co
GenerateArrayTransformFunction::new);
}
+ List<ExpressionContext> arguments = function.getArguments();
+ int numArguments = arguments.size();
+
+ // Build child transform functions first to derive argument data types
for scalar function polymorphism
+ List<TransformFunction> transformFunctionArguments = new
ArrayList<>(numArguments);
+ for (ExpressionContext argument : arguments) {
+
transformFunctionArguments.add(TransformFunctionFactory.get(argument,
columnContextMap, queryContext));
+ }
Review Comment:
Bad AI - they're only being built once, the older code was simply moved up
in this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
