9aman commented on code in PR #16783:
URL: https://github.com/apache/pinot/pull/16783#discussion_r2371581789
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerGauge.java:
##########
@@ -85,19 +85,19 @@ public enum ServerGauge implements AbstractMetrics.Gauge {
*/
NETTY_POOLED_THREADLOCALCACHE("bytes", true),
NETTY_POOLED_CHUNK_SIZE("bytes", true),
- // Ingestion delay metrics
- REALTIME_INGESTION_DELAY_MS("milliseconds", false),
- END_TO_END_REALTIME_INGESTION_DELAY_MS("milliseconds", false),
Review Comment:
I was being set in the IngestionDelayTracker before. Do we know why this was
added and what scenarios could it help to debug.
Referring to
```
if (firstStreamIngestionTimeMs > 0) {
_serverMetrics.setOrUpdatePartitionGauge(_metricName, partitionId,
ServerGauge.END_TO_END_REALTIME_INGESTION_DELAY_MS,
() -> getPartitionEndToEndIngestionDelayMs(partitionId));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
