harold-kfuse commented on code in PR #16965:
URL: https://github.com/apache/pinot/pull/16965#discussion_r2408972032
##########
pinot-plugins/pinot-stream-ingestion/pinot-kafka-3.0/src/main/java/org/apache/pinot/plugin/stream/kafka30/KafkaPartitionLevelConnectionHandler.java:
##########
@@ -78,16 +80,38 @@ private Properties buildProperties(StreamConfig
streamConfig) {
consumerProp.put(ConsumerConfig.ISOLATION_LEVEL_CONFIG,
_config.getKafkaIsolationLevel());
}
consumerProp.put(ConsumerConfig.CLIENT_ID_CONFIG, _clientId);
+ if (consumerProp.containsKey(ConsumerConfig.AUTO_OFFSET_RESET_CONFIG)
+ &&
consumerProp.getProperty(ConsumerConfig.AUTO_OFFSET_RESET_CONFIG).equals("smallest"))
{
Review Comment:
It's not relevant to this change here. I was doing some other testing. But
we may want to take it in too as part of a different PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
