gortiz commented on code in PR #16915:
URL: https://github.com/apache/pinot/pull/16915#discussion_r2402316960
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/GrpcSendingMailbox.java:
##########
@@ -98,6 +98,8 @@ public void send(MseBlock.Data data)
public void send(MseBlock.Eos block, List<DataBuffer> serializedStats)
throws IOException, TimeoutException {
sendInternal(block, serializedStats);
+ LOGGER.debug("Completing mailbox: {}", _id);
+ _contentObserver.onCompleted();
Review Comment:
Notice that we need to call onCompleted even when an error is received.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
