gortiz commented on code in PR #16903:
URL: https://github.com/apache/pinot/pull/16903#discussion_r2402343937
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/utils/BlockingMultiStreamConsumer.java:
##########
@@ -393,7 +395,7 @@ protected ReceivingMailbox.MseBlockWithStats onTimeout() {
return onException(terminateException.getErrorCode(),
terminateException.getMessage());
}
// TODO: Add the sender stage id to the error message
- String errMsg = "Timed out on stage " + _stageId + " waiting for data
sent by a child stage";
+ String errMsg = "Timed out on stage " + _stageId + " waiting for data
from child stage " + _senderStageId;
Review Comment:
This is wrong. StringBuilders won't make the code easier to read and
String.format is orders of magnitude slower than string concatenation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
