swaminathanmanish commented on code in PR #16908:
URL: https://github.com/apache/pinot/pull/16908#discussion_r2387105855
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java:
##########
@@ -79,12 +79,12 @@ public class RetentionManager extends
ControllerPeriodicTask<Void> {
public static final long OLD_LLC_SEGMENTS_RETENTION_IN_MILLIS =
TimeUnit.DAYS.toMillis(5L);
public static final int DEFAULT_UNTRACKED_SEGMENTS_DELETION_BATCH_SIZE = 100;
private static final RetryPolicy DEFAULT_RETRY_POLICY =
RetryPolicies.randomDelayRetryPolicy(20, 100L, 200L);
- private final boolean _untrackedSegmentDeletionEnabled;
- private final int _untrackedSegmentsRetentionTimeInDays;
+ private boolean _untrackedSegmentDeletionEnabled;
Review Comment:
Can you make the 3 vars volatile that ensures visibility of changes across
threads, since they are updated by one thread and read in another.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
