Jackie-Jiang commented on code in PR #16999:
URL: https://github.com/apache/pinot/pull/16999#discussion_r2422150655
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/GrpcSendingMailbox.java:
##########
@@ -73,14 +75,16 @@ public class GrpcSendingMailbox implements SendingMailbox {
private StreamObserver<MailboxContent> _contentObserver;
public GrpcSendingMailbox(String id, ChannelManager channelManager, String
hostname, int port, long deadlineMs,
- StatMap<MailboxSendOperator.StatKey> statMap, int maxByteStringSize) {
+ StatMap<MailboxSendOperator.StatKey> statMap, int maxInboundMessageSize,
int maxByteStringSize) {
Review Comment:
Given we already pass in `maxInboundMessageSize`, and we know
`NonSplitSender` won't be able to send the data, can we make a special sender
so that it decides whether to split the block based on the block size? This way
we can prevent this error completely.
#15694 was included in `1.4.0`, so this change won't introduce backward
incompatibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
