J-HowHuang commented on code in PR #16956:
URL: https://github.com/apache/pinot/pull/16956#discussion_r2403466303


##########
pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/rebalance/tenant/TenantRebalancerTest.java:
##########
@@ -90,6 +90,7 @@ public void setUp()
     startController();
     addFakeBrokerInstancesToAutoJoinHelixCluster(1, true);
     _executorService = Executors.newFixedThreadPool(3);
+    ZkBasedTenantRebalanceObserver._defaultZkUpdateMaxRetries = 15;

Review Comment:
   We don't directly construct a `ZKBasedTenantRebalanceObserver`, it's 
constructed by `TenantRebalancer`. We'll then have to expose this as a 
parameter at the rebalancer level, in which case I thought directly changing 
the static value is better?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to