somandal commented on code in PR #17028:
URL: https://github.com/apache/pinot/pull/17028#discussion_r2441394944
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentIndexCreationDriverImpl.java:
##########
@@ -542,6 +541,10 @@ private void buildStarTreeV2IfNecessary(File indexDir)
MultipleTreesBuilder builder = new
MultipleTreesBuilder(starTreeIndexConfigs, enableDefaultStarTree, indexDir,
buildMode)) {
builder.build();
+ } catch (Exception e) {
+ String tableNameWithType = _config.getTableConfig().getTableName();
+ LOGGER.error("Failed to build star-tree index for table: {},
skipping", tableNameWithType, e);
+ MinionMetrics.get().addMeteredTableValue(tableNameWithType,
MinionMeter.STAR_TREE_INDEX_BUILD_FAILURES, 1);
Review Comment:
yeah i'm confused about this too, but see that the `build()` was already
updating MinionMetrics:
```
MinionMetrics metrics = MinionMetrics.get();
String tableNameWithType = _config.getTableConfig().getTableName();
if (_incompleteRowsFound > 0) {
metrics.addMeteredTableValue(tableNameWithType,
MinionMeter.TRANSFORMATION_ERROR_COUNT, _incompleteRowsFound);
}
if (_skippedRowsFound > 0) {
metrics.addMeteredTableValue(tableNameWithType,
MinionMeter.DROPPED_RECORD_COUNT, _skippedRowsFound);
}
if (_sanitizedRowsFound > 0) {
metrics.addMeteredTableValue(tableNameWithType,
MinionMeter.CORRUPTED_RECORD_COUNT, _sanitizedRowsFound);
}
```
Perhaps this should be fixed, but don't think clear context is available
here to differentiate between build due to realtime conversion vs. minion. Any
suggestions? happy to fix this (or can fix as a follow-up)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
