yashmayya commented on code in PR #16957:
URL: https://github.com/apache/pinot/pull/16957#discussion_r2407459681
##########
pinot-controller/pom.xml:
##########
@@ -92,6 +92,10 @@
<artifactId>mockito-core</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.pinot</groupId>
+ <artifactId>pinot-java-client</artifactId>
+ </dependency>
Review Comment:
Let's not add this dependency, I'd suggest moving `TableNameExtractor` to
`pinot-common` instead.
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java:
##########
@@ -297,6 +331,20 @@ public boolean isIgnoreCase() {
}
}
+ public static class TableNamesExtractionRequest {
+ private final List<String> _sqls;
Review Comment:
Why does the request need to be a list of SQL queries? Can't we loop on the
client side instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
