ankitsultana commented on code in PR #17030:
URL: https://github.com/apache/pinot/pull/17030#discussion_r2437706609
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -571,6 +571,15 @@ public static class Broker {
"pinot.broker.multistage.lite.mode.leaf.stage.fanOutAdjustedLimit";
public static final int
DEFAULT_LITE_MODE_LEAF_STAGE_FAN_OUT_ADJUSTED_LIMIT = -1;
+ /**
+ * Whether to enable JOIN queries when MSE Lite mode is enabled. By
default joins are disabled
+ * in lite mode unless explicitly enabled. This value cannot be overridden
by query option.
+ */
+ public static final String CONFIG_OF_LITE_MODE_ENABLE_JOINS =
+ "pinot.broker.multistage.lite.mode.enable.joins";
+ public static final boolean DEFAULT_LITE_MODE_ENABLE_JOINS = false;
Review Comment:
I think by default we should set this to true in open-source since otherwise
quickstarts and other places will require additional server configs.
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/physical/v2/PRelNodeTreeValidator.java:
##########
@@ -37,8 +39,37 @@ private PRelNodeTreeValidator() {
* Validate the tree rooted at the given PRelNode. Ideally all issues with
the plan should be caught even with an
* EXPLAIN, hence this method should be called as part of query compilation
itself.
*/
- public static void validate(PRelNode rootNode) {
- // TODO(mse-physical): Add plan validations here.
+ public static void validate(PRelNode rootNode, PhysicalPlannerContext
context) {
+ if (context == null) {
+ return;
+ }
+ // TODO(mse-physical): Add more plan validations here.
Review Comment:
I think we can remove this TODO now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
