rohityadav1993 commented on code in PR #16727: URL: https://github.com/apache/pinot/pull/16727#discussion_r2430164422
########## pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/creator/impl/ColumnarSegmentBuildingTest.java: ########## @@ -0,0 +1,500 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.segment.creator.impl; + +import com.google.common.collect.Lists; +import java.io.File; +import java.io.IOException; +import java.math.BigDecimal; +import java.util.ArrayList; +import java.util.List; +import java.util.Map; +import java.util.Set; +import javax.annotation.Nullable; +import org.apache.commons.io.FileUtils; +import org.apache.pinot.segment.local.indexsegment.immutable.ImmutableSegmentLoader; +import org.apache.pinot.segment.local.segment.readers.PinotSegmentColumnReaderFactory; +import org.apache.pinot.segment.spi.ImmutableSegment; +import org.apache.pinot.segment.spi.creator.SegmentGeneratorConfig; +import org.apache.pinot.spi.config.table.TableConfig; +import org.apache.pinot.spi.config.table.TableType; +import org.apache.pinot.spi.data.FieldSpec; +import org.apache.pinot.spi.data.Schema; +import org.apache.pinot.spi.data.readers.ColumnReader; +import org.apache.pinot.spi.data.readers.GenericRow; +import org.apache.pinot.spi.data.readers.RecordReader; +import org.apache.pinot.spi.data.readers.RecordReaderConfig; +import org.apache.pinot.spi.utils.ReadMode; +import org.apache.pinot.spi.utils.builder.TableConfigBuilder; +import org.testng.Assert; +import org.testng.annotations.AfterClass; +import org.testng.annotations.BeforeClass; +import org.testng.annotations.Test; + + +/** + * Tests for columnar segment building functionality. + * + * <p>This test class validates the new columnar segment building capability including: + * <ul> + * <li>ColumnReader interface implementations</li> + * <li>ColumnReaderFactory for different data sources</li> + * <li>Columnar segment building vs row-major building equivalence</li> + * <li>Support for new columns with default values</li> + * </ul> + */ +public class ColumnarSegmentBuildingTest { + private static final String TEMP_DIR = System.getProperty("java.io.tmpdir"); + private static final String TABLE_NAME = "testTable"; + private static final String SEGMENT_NAME = "testSegment"; + + // Test columns + private static final String STRING_COL_1 = "stringCol1"; + private static final String STRING_COL_2 = "stringCol2"; + private static final String INT_COL_1 = "intCol1"; + private static final String INT_COL_2 = "intCol2"; + private static final String LONG_COL = "longCol"; + private static final String FLOAT_COL = "floatCol"; + private static final String DOUBLE_COL = "doubleCol"; + private static final String BIG_DECIMAL_COL = "bigDecimalCol"; + private static final String BYTES_COL = "bytesCol"; + private static final String TIME_COL = "timeCol"; + private static final String MV_INT_COL = "mvIntCol"; + private static final String MV_STRING_COL = "mvStringCol"; + + // New column for testing default value handling + private static final String NEW_STRING_COL = "newStringCol"; + private static final String NEW_INT_COL = "newIntCol"; + + private File _tempDir; + private Schema _originalSchema; + private Schema _extendedSchema; // Schema with additional columns + private TableConfig _tableConfig; + private List<GenericRow> _testData; + + @BeforeClass + public void setUp() throws IOException { + _tempDir = new File(TEMP_DIR, "ColumnarSegmentBuildingTest"); + FileUtils.deleteQuietly(_tempDir); + _tempDir.mkdirs(); + + // Create original schema + _originalSchema = new Schema.SchemaBuilder() + .addSingleValueDimension(STRING_COL_1, FieldSpec.DataType.STRING) + .addSingleValueDimension(STRING_COL_2, FieldSpec.DataType.STRING) + .addSingleValueDimension(INT_COL_1, FieldSpec.DataType.INT) + .addSingleValueDimension(INT_COL_2, FieldSpec.DataType.INT) + .addSingleValueDimension(LONG_COL, FieldSpec.DataType.LONG) + .addSingleValueDimension(FLOAT_COL, FieldSpec.DataType.FLOAT) + .addSingleValueDimension(DOUBLE_COL, FieldSpec.DataType.DOUBLE) + .addSingleValueDimension(BIG_DECIMAL_COL, FieldSpec.DataType.BIG_DECIMAL) + .addSingleValueDimension(BYTES_COL, FieldSpec.DataType.BYTES) + .addMultiValueDimension(MV_INT_COL, FieldSpec.DataType.INT) + .addMultiValueDimension(MV_STRING_COL, FieldSpec.DataType.STRING) + .addDateTime(TIME_COL, FieldSpec.DataType.LONG, "1:MILLISECONDS:EPOCH", "1:MILLISECONDS") + .build(); + + // Create extended schema with additional columns + _extendedSchema = new Schema.SchemaBuilder() + .addSingleValueDimension(STRING_COL_1, FieldSpec.DataType.STRING) + .addSingleValueDimension(STRING_COL_2, FieldSpec.DataType.STRING) + .addSingleValueDimension(INT_COL_1, FieldSpec.DataType.INT) + .addSingleValueDimension(INT_COL_2, FieldSpec.DataType.INT) + .addSingleValueDimension(LONG_COL, FieldSpec.DataType.LONG) + .addSingleValueDimension(FLOAT_COL, FieldSpec.DataType.FLOAT) + .addSingleValueDimension(DOUBLE_COL, FieldSpec.DataType.DOUBLE) + .addSingleValueDimension(BIG_DECIMAL_COL, FieldSpec.DataType.BIG_DECIMAL) + .addSingleValueDimension(BYTES_COL, FieldSpec.DataType.BYTES) + .addMultiValueDimension(MV_INT_COL, FieldSpec.DataType.INT) + .addMultiValueDimension(MV_STRING_COL, FieldSpec.DataType.STRING) + .addDateTime(TIME_COL, FieldSpec.DataType.LONG, "1:MILLISECONDS:EPOCH", "1:MILLISECONDS") + .addSingleValueDimension(NEW_STRING_COL, FieldSpec.DataType.STRING) + .addSingleValueDimension(NEW_INT_COL, FieldSpec.DataType.INT) + .build(); + + // Create table config + _tableConfig = new TableConfigBuilder(TableType.OFFLINE) + .setTableName(TABLE_NAME) + .setTimeColumnName(TIME_COL) + .setInvertedIndexColumns(Lists.newArrayList(STRING_COL_1, INT_COL_1)) Review Comment: There is no logic based on index type in columnar segment build. This will not add value to the PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
