jayeshchoudhary commented on code in PR #16977:
URL: https://github.com/apache/pinot/pull/16977#discussion_r2414553094


##########
pinot-controller/src/main/resources/app/requests/index.ts:
##########
@@ -209,8 +209,8 @@ export const getTasks = (tableName: string, taskType: 
string): Promise<AxiosResp
 export const getTaskRuntimeConfig = (taskName: string): 
Promise<AxiosResponse<TaskRuntimeConfig>> =>
   baseApi.get(`/tasks/task/${taskName}/runtime/config`, { headers: { 
...headers, Accept: 'application/json' }});
 
-export const getTaskDebug = (taskName: string): 
Promise<AxiosResponse<OperationResponse>> =>
-  baseApi.get(`/tasks/task/${taskName}/debug?verbosity=1`, { headers: { 
...headers, Accept: 'application/json' } });
+export const getTaskDebug = (taskName: string, tableName: string): 
Promise<AxiosResponse<OperationResponse>> =>
+  
baseApi.get(`/tasks/task/${taskName}/debug?verbosity=1&tableName=${tableName}`, 
{ headers: { ...headers, Accept: 'application/json' } });

Review Comment:
   afaik table name convention does not contain any special chars
   if it contains numbers then yes we need to url encode the table name to read 
correct value



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to