yashmayya commented on code in PR #16980:
URL: https://github.com/apache/pinot/pull/16980#discussion_r2415070273
##########
pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/statement/StatementOptimizer.java:
##########
@@ -31,5 +30,5 @@
public interface StatementOptimizer {
/** Optimize the given SQL statement. */
- void optimize(PinotQuery query, @Nullable TableConfig tableConfig, @Nullable
Schema schema);
+ void optimize(PinotQuery query, @Nullable Schema schema);
Review Comment:
`JsonStatementOptimizer` was the only one using `TableConfig` and that
optimizer itself isn't being used at all. There was a bug with optimizing
queries on hybrid tables in `BaseSingleStageBrokerRequestHandler` and this
patch fixes the bug and simplifies applying these optimizers by removing the
unnecessary `TableConfig`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
