somandal commented on code in PR #16857:
URL: https://github.com/apache/pinot/pull/16857#discussion_r2412372190
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java:
##########
@@ -691,8 +745,46 @@ public synchronized Map<String, TaskSchedulingInfo>
scheduleTasks(TaskScheduling
if (taskGenerator != null) {
_helixTaskResourceManager.ensureTaskQueueExists(taskType);
addTaskTypeMetricsUpdaterIfNeeded(taskType);
- tasksScheduled.put(taskType, scheduleTask(taskGenerator,
enabledTableConfigs, context.isLeader(),
- context.getMinionInstanceTag(), context.getTriggeredBy()));
+
+ // Take the lock for all tables for which to schedule the tasks and
pass the list of tables for which getting
+ // the lock was successful
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
