yashmayya commented on code in PR #16939:
URL: https://github.com/apache/pinot/pull/16939#discussion_r2399794891
##########
.mvn/jvm.config:
##########
@@ -0,0 +1,8 @@
+--add-opens=java.base/java.nio=ALL-UNNAMED
+--add-opens=java.base/sun.nio.ch=ALL-UNNAMED
+--add-opens=java.base/java.lang=ALL-UNNAMED
+--add-opens=java.base/java.util=ALL-UNNAMED
+--add-opens=java.base/java.lang.reflect=ALL-UNNAMED
+--add-opens=java.base/jdk.internal.misc=ALL-UNNAMED
+-Dio.netty.tryReflectionSetAccessible=true
+-Dio.grpc.netty.shaded.io.netty.tryReflectionSetAccessible=true
Review Comment:
Is this for tests?
##########
pinot-broker/src/main/java/org/apache/pinot/broker/grpc/BrokerGrpcServer.java:
##########
@@ -168,6 +169,15 @@ private void registerBufferMetrics(PooledByteBufAllocator
bufAllocator, BrokerMe
brokerMetrics.setOrUpdateGlobalGauge(BrokerGauge.GRPC_NETTY_POOLED_CACHE_SIZE_NORMAL,
metric::normalCacheSize);
brokerMetrics.setOrUpdateGlobalGauge(BrokerGauge.GRPC_NETTY_POOLED_THREADLOCALCACHE,
metric::numThreadLocalCaches);
brokerMetrics.setOrUpdateGlobalGauge(BrokerGauge.GRPC_NETTY_POOLED_CHUNK_SIZE,
metric::chunkSize);
+ // Notice here we are using
io.grpc.netty.shaded.io.netty.util.internal.PlatformDependent instead of
+ // io.netty.util.internal.PlatformDependent because gRPC shades Netty to
avoid version conflicts.
+ // This also means it uses a different pool of direct memory and a
different setting of max direct memory.
+ //
+ // Also notice these two metrics are also set by GrpcQueryService. Both
are set to the same value, so it
+ // doesn't matter which one _wins_ in the metrics system.
Review Comment:
Wouldn't it still be better to set it in a single place per broker / server
JVM instance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
