krishan1390 commented on PR #16921: URL: https://github.com/apache/pinot/pull/16921#issuecomment-3349766144
> > LGTM, but looks like a bunch of tests in `ForwardIndexHandlerTest` and `SegmentPreProcessorTest` need to be updated. > > This actually revealed another bug where we didn't update `bitsPerElement` when converting raw index to dictionary-encoded. Updated the PR to fix the bug and add comments to revisit `bitsPerElement` after the next release There are few more failures in LLCRealtimeClusterIntegrationTest. I too had faced them ad fixed in along with new tests - https://github.com/apache/pinot/pull/16845/commits/fa518fbd3a36c144a2182d7c57d125d4b1bc564c#diff-9647059363c9ffa3c7519dbf527d75e5bdd25dcf278ca6ee5a02708b54155dd1 should we cherry pick those changes to this PR ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
