Jackie-Jiang commented on code in PR #16911:
URL: https://github.com/apache/pinot/pull/16911#discussion_r2383231806
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -778,15 +753,6 @@ public List<String> getAllTables(@Nullable String
databaseName) {
databaseName)).collect(Collectors.toList());
}
- /**
- * Get all offline table names from all databases.
- *
- * @return List of offline table names
- */
- public List<String> getAllOfflineTables() {
Review Comment:
The getters for table names without database might still be useful for
cluster management (e.g. `getAllTables()` are still used). We might want to
keep them
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -2255,7 +2195,7 @@ public void deleteTable(String tableName, TableType
tableType, @Nullable String
LOGGER.info("Deleting table {}: Removed segment metadata",
tableNameWithType);
// Remove COMMITTING segment list
- if (TableNameBuilder.REALTIME.equals(tableType)) {
+ if (TableType.REALTIME.equals(tableType)) {
Review Comment:
Good catch! We can change it to
```suggestion
if (tableType == TableType.REALTIME) {
```
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -428,7 +414,7 @@ public LineageManager getLineageManager() {
/**
* Instance related APIs
- */
+ * /
Review Comment:
(nit) Revert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
