Jackie-Jiang commented on code in PR #16900:
URL: https://github.com/apache/pinot/pull/16900#discussion_r2380054953
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java:
##########
@@ -258,6 +259,24 @@ public Boolean call() {
} catch (ZkBadVersionException e) {
LOGGER.warn("Version changed while updating ideal state for
resource: {}", resourceName);
return false;
+ } catch (ZkInterruptedException e) {
+ LOGGER.warn("Caught ZkInterruptedException while updating
resource: {}, verifying...",
+ resourceName);
+ IdealState writtenIdealState =
dataAccessor.getProperty(idealStateKey);
Review Comment:
Should we do another try-catch over this handling?
I feel the interruption might mostly be triggered when controller
disconnects from the cluster, in which case we probably no longer be able to
access the ZK. Can you verify that?
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java:
##########
@@ -258,6 +259,24 @@ public Boolean call() {
} catch (ZkBadVersionException e) {
LOGGER.warn("Version changed while updating ideal state for
resource: {}", resourceName);
return false;
+ } catch (ZkInterruptedException e) {
+ LOGGER.warn("Caught ZkInterruptedException while updating
resource: {}, verifying...",
Review Comment:
Please add some comment explaining why we are doing this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
