Jackie-Jiang commented on PR #16867: URL: https://github.com/apache/pinot/pull/16867#issuecomment-3330854509
Digging more into the code, I'm still trying to figure out when will it get `ZkInterruptedException` but with IS persisted. So far I have found Helix `ZkClient.writeDataReturnStat()` -> `ZkClient.retryUntilConnected()` could throw `ZkInterruptedException` but it shouldn't persist the IS. The fix in this PR is not general enough because the core problem is IS update result is no longer consistent, which could impact a lot of logics, in addition to segment upload. We need to fix the IS update logic to ensure it either successfully persist the result, or throw exception. @xiangfu0 Can you help take a look at this? Can we handle this in `IdealStateGroupCommit`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
