mohgeis opened a new issue, #16880:
URL: https://github.com/apache/pinot/issues/16880

   **What needs to be done?**
   
   Add support for configuring sidecar containers in the Pinot Helm chart for 
all Pinot components (Controller, Broker, Server, and Minion). Currently, the 
Helm chart supports init containers (added in #15274) but lacks support for 
sidecar containers that run alongside the main Pinot containers throughout 
their lifecycle.
   
   **Why is this feature needed?**
   
   Sidecar containers are a common Kubernetes pattern used for various 
operational purposes including:
   - Monitoring and Observability: Deploying monitoring and logs agents.
   - Security: Deploying security agents for runtime protection, vulnerability 
scanning, etc..
   - Service Mesh, Backup and Data Management, Configuration Management, etc..
   
   Without native Helm chart support, users must either: manually patch the 
generated StatefulSets/Deployments (maintenance overhead) or Use workarounds 
that may not follow Kubernetes best practices.
   
   **Proposed Implementation**
   
   Similar to the existing initContainers implementation, add support for 
sidecarContainers (or additionalContainers) configuration in the Helm chart 
values for each Pinot component:
   
   ```yaml
   controller:
     sidecarContainers: []
       # - name: monitoring-agent
       #   image: datadog/agent:latest
       #   env:
       #     - name: DD_API_KEY
       #       valueFrom:
       #         secretKeyRef:
       #           name: datadog-secret
       #           key: api-key
   
   broker:
     sidecarContainers: []
   
   server:
     sidecarContainers: []
   
   minion:
     sidecarContainers: []
   
   minionStateless:
     sidecarContainers: []
   ```
   
   The implementation should:
   1. Allow full container specification (image, env, resources, volumes, etc.)
   2. Support volume sharing between main container and sidecars when needed
   3. Follow the same pattern as the existing initContainers implementation for 
consistency
   4. Include proper validation and documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to