9aman commented on code in PR #16783:
URL: https://github.com/apache/pinot/pull/16783#discussion_r2371585044
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java:
##########
@@ -160,8 +159,7 @@ public RealtimeTableDataManager(Semaphore
segmentBuildSemaphore, Supplier<Boolea
protected void doInit() {
_leaseExtender = SegmentBuildTimeLeaseExtender.getOrCreate(_instanceId,
_serverMetrics, _tableNameWithType);
// Tracks ingestion delay of all partitions being served for this table
- _ingestionDelayTracker =
- new IngestionDelayTracker(_serverMetrics, _tableNameWithType, this,
_isServerReadyToServeQueries);
Review Comment:
Are we doing away with the requirement of tracking ingestion after the
server has been marked ready to serve queries ?
FreshnessBasedChecker kind of ensures that we don't have too much lag. Will
it impacts any alerting based on this metric for servers that are restarting ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
