Copilot commented on code in PR #16870:
URL: https://github.com/apache/pinot/pull/16870#discussion_r2370589710
##########
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java:
##########
@@ -562,9 +562,11 @@ protected WorkloadBudgetManager
createWorkloadBudgetManager(PinotConfiguration b
private QueryDispatcher createQueryDispatcher(PinotConfiguration brokerConf)
{
String hostname =
_brokerConf.getProperty(CommonConstants.MultiStageQueryRunner.KEY_OF_QUERY_RUNNER_HOSTNAME);
- int port = Integer.parseInt(_brokerConf.getProperty(
- CommonConstants.MultiStageQueryRunner.KEY_OF_QUERY_RUNNER_PORT));
- return new QueryDispatcher(new MailboxService(hostname, port,
_brokerConf), _failureDetector);
+ int port =
+
Integer.parseInt(_brokerConf.getProperty(CommonConstants.MultiStageQueryRunner.KEY_OF_QUERY_RUNNER_PORT));
+ return new QueryDispatcher(
+ new MailboxService(hostname, port,
org.apache.pinot.spi.config.instance.InstanceType.BROKER, _brokerConf),
Review Comment:
Use the imported class name instead of fully qualified name. Add `import
org.apache.pinot.spi.config.instance.InstanceType;` at the top and use
`InstanceType.BROKER` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
