suvodeep-pyne opened a new pull request, #16869: URL: https://github.com/apache/pinot/pull/16869
## Summary - Introduces comprehensive metrics collection for Pinot's audit logging system to provide visibility into audit processing performance and failures - Adds AuditMetrics abstraction layer that routes metrics to appropriate component (Controller/Broker) - Instruments audit request/response processing with timing and failure metrics ## Changes Made - **New AuditMetrics class**: Abstraction layer that handles routing metrics to component-specific metrics (Controller vs Broker) based on service role - **Enhanced AuditLogFilter**: Added timing instrumentation for request/response processing with graceful error handling - **Updated AuditRequestProcessor**: Added metrics for payload truncation events - **Metrics definitions**: Added corresponding timer and meter definitions to Controller/Broker metrics classes - **Service binding updates**: Modified audit service bindings to inject metrics dependencies - **Test updates**: Updated unit tests to accommodate new metrics dependencies ## Key Features - **Component-agnostic metrics**: Single API that works across Controller and Broker components - **Graceful degradation**: Audit failures never impact main request processing - **Comprehensive coverage**: Tracks request processing time, response processing time, failure rates, and payload truncation events - **Type-safe delegation**: Uses functional interfaces for efficient metric recording ## Test Plan - [x] Unit tests updated and passing - [x] Existing audit functionality preserved - [ ] Integration testing with metrics collection enabled - [ ] Verify metrics appear in monitoring dashboards - [ ] Performance testing to ensure minimal overhead -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
