noob-se7en commented on PR #16847:
URL: https://github.com/apache/pinot/pull/16847#issuecomment-3311172132
> What is the behavior now when a pauseless segment starts from `COMMITTING`
state? Some javadoc would be helpful
The behavior is undefined. The state of FSM can be either
`COMMITTER_UPLOADING` or `COMMITTING` if fsm is being created and it segment zk
status is `COMMITTING`.
The current behaviour will be that segment protocol call will fail, FSM will
be aborted and segment will be left in COMMITTING state leaving it to RVM to
fix it.
Its hard to set _state for committing segment in constructor given that we
don't know if the current call is made by the winner or not.
segmentCommitEnd requires below condition to proceed:
```
if
(_state.equals(BlockingSegmentCompletionFSMState.COMMITTER_UPLOADING) &&
instanceId.equals(_winner)
&& offset.compareTo(_winningOffset) != 0) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
