9aman commented on code in PR #16848:
URL: https://github.com/apache/pinot/pull/16848#discussion_r2361948470
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/SegmentDeletionManager.java:
##########
@@ -270,49 +257,6 @@ public void removeSegmentsFromStoreInBatch(String
tableNameWithType, List<String
}
}
- private void deleteSegmentMetadataFromStore(PinotFS pinotFS, URI
segmentFileUri, String segmentId) {
- // Check if segment metadata exists in remote store and delete it.
- // URI is generated from segment's location and segment name
- try {
- URI segmentMetadataUri =
SegmentPushUtils.generateSegmentMetadataURI(segmentFileUri.toString(),
segmentId);
Review Comment:
This code is related to batch deletion of segments in Deleted_Segments
directory. No metadata exists for such segments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
