suvodeep-pyne commented on code in PR #16843:
URL: https://github.com/apache/pinot/pull/16843#discussion_r2356962411
##########
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/genericrow/GenericRowDeserializer.java:
##########
@@ -266,6 +278,23 @@ public int compare(long offset1, long offset2, int
numFieldsToCompare) {
offset2 += numBytes2;
break;
}
+ case MAP: {
+ int numBytes1 = _dataBuffer.getInt(offset1);
+ offset1 += Integer.BYTES;
+ byte[] mapBytes1 = new byte[numBytes1];
+ _dataBuffer.copyTo(offset1, mapBytes1);
+ int numBytes2 = _dataBuffer.getInt(offset2);
+ offset2 += Integer.BYTES;
+ byte[] mapBytes2 = new byte[numBytes2];
+ _dataBuffer.copyTo(offset2, mapBytes2);
+ int result = ByteArray.compare(mapBytes1, mapBytes2);
Review Comment:
Q: is this just for basic tie breaking? Are there any semantic requirements
here like comparing by # keys, etc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
