ankitsultana commented on code in PR #16777:
URL: https://github.com/apache/pinot/pull/16777#discussion_r2349528876
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/generator/BaseTaskGenerator.java:
##########
@@ -68,17 +68,35 @@ public long getTaskTimeoutMs() {
}
@Override
- public int getNumConcurrentTasksPerInstance() {
+ public int getNumConcurrentTasksPerInstance(String minionTag) {
String taskType = getTaskType();
- String configKey = taskType +
MinionConstants.NUM_CONCURRENT_TASKS_PER_INSTANCE_KEY_SUFFIX;
- String configValue = _clusterInfoAccessor.getClusterConfig(configKey);
+
+ // Priority 1: Check minion tenant specific cluster config
+ if (minionTag != null) {
Review Comment:
I think this logic of first checking tenant level config, and then task
level config, should be moved to another generic method, to ensure that the
same semantics can get re-used for all minion cluster configs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
