xiangfu0 opened a new pull request, #16810:
URL: https://github.com/apache/pinot/pull/16810
This pull request improves the handling of segment completion and online
transitions when using the DOWNLOAD completion mode in the
`RealtimeSegmentDataManager`. The main focus is to ensure that the system
checks for a valid download URL before attempting to download a segment, and
provides clear logging and fallback behavior if the URL is missing or invalid.
**Enhancements to segment completion and transition logic:**
* When in KEEP state and using DOWNLOAD mode, the code now fetches fresh
metadata from ZooKeeper to check if a download URL is available. If the URL is
missing or invalid, it logs a warning and falls back to retaining the segment
instead of attempting a download.
* During the transition from consuming to online, the code checks for the
presence of a download URL before downloading a segment. If the URL is missing,
it logs a warning and falls back to building the segment locally.
[[1]](diffhunk://#diff-fd2e3e273d7742190b27e7b26472460ff5dc6038f895e8647972b205fa8edccaL1463-R1497)
[[2]](diffhunk://#diff-fd2e3e273d7742190b27e7b26472460ff5dc6038f895e8647972b205fa8edccaL1513-L1516)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
