deemoliu commented on code in PR #15258: URL: https://github.com/apache/pinot/pull/15258#discussion_r2345331455
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/compression/DeltaCompressor.java: ########## @@ -0,0 +1,132 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.io.compression; + +import java.io.IOException; +import java.nio.ByteBuffer; +import net.jpountz.lz4.LZ4Factory; +import org.apache.pinot.segment.spi.compression.ChunkCompressionType; +import org.apache.pinot.segment.spi.compression.ChunkCompressor; + + +/** + * Implementation of {@link ChunkCompressor} using delta compression with LZ4. Review Comment: thanks @chenboat i plan to add a ZSTD version after this PR. the current interface of compressionCodec doesn't take a parameter. But i can make it configurable on the server config in the following PRs. ########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/compression/DeltaCompressor.java: ########## @@ -0,0 +1,132 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.io.compression; + +import java.io.IOException; +import java.nio.ByteBuffer; +import net.jpountz.lz4.LZ4Factory; +import org.apache.pinot.segment.spi.compression.ChunkCompressionType; +import org.apache.pinot.segment.spi.compression.ChunkCompressor; + + +/** + * Implementation of {@link ChunkCompressor} using delta compression with LZ4. + * The delta values are further compressed using LZ4. + */ +class DeltaCompressor implements ChunkCompressor { + + static final DeltaCompressor INSTANCE = new DeltaCompressor(); + static final LZ4Factory LZ4_FACTORY = LZ4Factory.fastestInstance(); Review Comment: i can make it configurable on the server config in the following PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
