somandal opened a new pull request, #16706: URL: https://github.com/apache/pinot/pull/16706
The PR https://github.com/apache/pinot/pull/16348 introduced logic to treat pauseless ONLINE segments in COMMITTING status as CONSUMING segments to skip them during segment relocation. Whereas, the RealtimeSegmentAssignment code blindly moves segments that are put in the CONSUMING bucket to the CONSUMING state. This is no longer correct as segments in this bucket can belong to two different target states: 1. [pauseless and non-pauseless] CONSUMING segments 2. [pauseless] ONLINE segments with their segment ZK metadata indicating they are in COMMITTING status This PR resolves the above by using the actual originalInstanceStateMap to determine the target state rather than blindly moving all segments in this bucket to CONSUMING state cc @Jackie-Jiang @noob-se7en -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
