suvodeep-pyne commented on code in PR #16694:
URL: https://github.com/apache/pinot/pull/16694#discussion_r2304948086
##########
pinot-common/src/main/java/org/apache/pinot/common/audit/AuditConfig.java:
##########
@@ -36,7 +36,7 @@ public final class AuditConfig {
private boolean _captureRequestPayload = false;
@JsonProperty("capture.request.headers")
- private boolean _captureRequestHeaders = false;
+ private String _captureRequestHeaders = "";
Review Comment:
agree in a way. I just thought of keeping it consistent with OTEL standard.
https://opentelemetry.io/docs/zero-code/java/agent/instrumentation/http/
Yes. This is a breaking change where it is now a list of allowed headers.
For booleans, I am using a suffix like `.enabled` to denote that.
example: `capture.request.payload.enabled`
I have also posted this for further feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
