bziobrowski commented on code in PR #16576:
URL: https://github.com/apache/pinot/pull/16576#discussion_r2293451927
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MultiStageOperator.java:
##########
@@ -223,6 +232,25 @@ protected Map<String, Plan.ExplainNode.AttributeValue>
getExplainAttributes() {
return Collections.emptyMap();
}
+ private long getGcTimeMillis() {
Review Comment:
I think the idea is good but mixing all gc collection times might make it
useless . When I run the code as test I see the following beans :
- g1 young generation
- g1 concurrent gc
- g1 old generation
I'm afraid metric it's going to be dominated by concurrent gc (which should
be ignored). Ideally, we'd be able to use metric to learn e.g. how long
operator was blocked due to stop-the-world gc events, but api doesn't really
allow it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
