deemoliu commented on code in PR #16692:
URL: https://github.com/apache/pinot/pull/16692#discussion_r2301730868
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/SegmentStatusChecker.java:
##########
@@ -479,7 +479,7 @@ private void updateSegmentMetrics(String tableNameWithType,
TableConfig tableCon
if (tableType == TableType.REALTIME && tableConfig != null) {
List<StreamConfig> streamConfigs =
IngestionConfigUtils.getStreamConfigs(tableConfig);
new MissingConsumingSegmentFinder(tableNameWithType, propertyStore,
_controllerMetrics,
- streamConfigs).findAndEmitMetrics(idealState);
+ streamConfigs, idealState).findAndEmitMetrics(idealState);
Review Comment:
is this a active/inactive flag for table level or topic level?
can you please add an example on the ideal state changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
